Repository navigation
Don't apply per-organization limits to requests without an organization - #7
Merged
maoueh merged 3 commits intoNov 12, 2026
Merged
Conversation
Worker keys end in -w1, -w2, ... since the workerKey reuse fix, but the test still expected -w0001.
With the null auth plugin no request carries an organization ID, so all of them were counted against one organization's session and worker limits: the default max_sessions_per_user=3 capped a whole tier1 at 3 streams. Requests without an organization now only count against the global limits.
Branch protection on main requires a `test` status check that no workflow reported. Also align dependabot.yml and secret-scanning.yml with the sf-operator GitHub provider templates.
maoueh
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the null auth plugin (firehose-core's default) no request carries an organization ID, so every request was counted against the same empty organization. With the default
max_sessions_per_user=3, a self-hosted tier1 allowed 3 concurrent streams in total, not 3 per caller. The same applied tomax_workers_per_organization.Requests without an organization now only count against the global
max_sessionsandmax_workerslimits, since there is no identity to share a per-organization limit with.TestLocalSessionPool_NoOrganizationfails on main.The first commit fixes
TestLocalSessionPool_GetWorker, which was already failing on main: it still expected-w0001worker keys after #3 changed them to-w1. The repo's CI doesn't run the tests, which is why it went unnoticed.