Skip to content

Don't apply per-organization limits to requests without an organization - #7

Merged
maoueh merged 3 commits into
streamingfast:mainfrom
aggris2:fix/no-org-limit-without-organization
Nov 12, 2026
Merged

maoueh merged 3 commits into
streamingfast:mainfrom
aggris2:fix/no-org-limit-without-organization

Conversation

@aggris2

@aggris2 aggris2 commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

With the null auth plugin (firehose-core's default) no request carries an organization ID, so every request was counted against the same empty organization. With the default max_sessions_per_user=3, a self-hosted tier1 allowed 3 concurrent streams in total, not 3 per caller. The same applied to max_workers_per_organization.

Requests without an organization now only count against the global max_sessions and max_workers limits, since there is no identity to share a per-organization limit with.

TestLocalSessionPool_NoOrganization fails on main.

The first commit fixes TestLocalSessionPool_GetWorker, which was already failing on main: it still expected -w0001 worker keys after #3 changed them to -w1. The repo's CI doesn't run the tests, which is why it went unnoticed.

Worker keys end in -w1, -w2, ... since the workerKey reuse fix, but the
test still expected -w0001.
With the null auth plugin no request carries an organization ID, so all
of them were counted against one organization's session and worker
limits: the default max_sessions_per_user=3 capped a whole tier1 at 3
streams. Requests without an organization now only count against the
global limits.
@dfuse-bot
dfuse-bot requested a review from maoueh November 6, 2026 21:07
Branch protection on main requires a `test` status check that no workflow
reported. Also align dependabot.yml and secret-scanning.yml with the
sf-operator GitHub provider templates.
@maoueh
maoueh merged commit 69e5a5d into streamingfast:main Nov 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants