Repository navigation
Bump dstore: local store finds files when the base path is . - #352
Merged
sduchesneau merged 1 commit intoNov 13, 2026
Merged
sduchesneau merged 1 commit into
sduchesneau merged 1 commit into
Conversation
Picks up streamingfast/dstore#64, so `firecore tools check merged-blocks .` reads the files of the current directory instead of reporting an empty range and "No hole found". Fixes streamingfast#56 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sduchesneau
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.
Bumps
github.com/streamingfast/dstoretov0.2.4-0.20261113162957-b1a065e7db73, the merge of streamingfast/dstore#64. This is the only dstore change since the previous pin (ed2936b).With a local store opened at
., dstore's walk skipped every file, sofirecore tools check merged-blocks .reported✅ Range [#0, #0]and🆗 No hole found.Tests
go test ./...passes.firecore tools check merged-blocks . -r 0:700, built from this branch, on a store with a hole at 300–499. It now prints✅ [#0, #299],❌ Range [#300, #499] (Missing, [300:500]),✅ [#500, #700]and🆘 Holes found!.Note: sum.golang.org didn't have this pseudo-version yet when I bumped it, so go.sum was filled from a direct fetch of the merged commit.
🤖 Generated with Claude Code