Repository navigation
tier1: refresh last_used markers during long-running requests - #1070
Merged
Merged
Conversation
- Default the refresh interval to 1h. - Defer the package write timeout cancel. - Skip a refresh tick once the request context is done. - Run TestEvery under testing/synctest. - Add changelog entry.
maoueh
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
last_used is written once at request start, so a stream that stays connected longer than the purge retention looks idle and its caches can be purged while in use.
Rewrite the markers every 6h for the lifetime of the request (WithLastUsedRefreshInterval, <= 0 disables).
Write every module's marker even if one fails, and give the package and marker writes separate timeouts.