Skip to content

Tiktok form validation and game persistence. - #6191

Open
michelinewu wants to merge 2 commits into
masterfrom
mw_tiktok_edit_stream_info
Open

michelinewu wants to merge 2 commits into
masterfrom
mw_tiktok_edit_stream_info

Conversation

@michelinewu

Copy link
Copy Markdown
Contributor

Persist the TikTok Game Selection and Require Stream Key Credentials When the Manual Form Is in Use

Fixes for the TikTok edit stream settings form.

Issues

The TikTok game did not survive a platform-settings refresh.

An approved TikTok account on the stream-key tab was never validated.

Fixes

  • Mirror Twitch and Kick to set game name.
  • Add more descriptive error message.
  • Add active tab tracking for form validation.

Performance Implications

None.

Copilot AI lite review requested due to automatic review settings September 17, 2026 20:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical game-routing defect and moderate tab/credential-path issues remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates TikTok Go Live settings to persist game selections and validate manual stream credentials based on the active tab.

Changes:

  • Tracks TikTok tabs and persists game IDs and names.
  • Adds conditional manual credential validation and localized messaging.
  • Updates platform game-selection handling.
File summaries
File Summary Final review comment
app/services/platforms/tiktok.ts Handles tab-specific streaming behavior and game persistence. Moderate (3 votes): Undefined activeTab can skip startStream and proceed with empty credentials; treat non-stream-key values as the Live Access path. Nit (1 vote): Correct “instead API” to “instead of the API.”
app/i18n/en-US/tiktok.json Adds the credential validation message. No final review comment.
app/components-react/windows/go-live/useGoLiveSettings.ts Validates manual TikTok credentials when required. No final review comment.
app/components-react/windows/go-live/platforms/TiktokEditStreamInfo.tsx Tracks tabs and conditionally requires credential fields. Moderate (2 votes): Make Tabs controlled from p.value.activeTab so the displayed tab matches validation and beforeGoLive.
app/components-react/windows/go-live/GameSelector.tsx Updates platform game information. Critical (3 votes): Twitch and Kick selections are sent to TikTokService, overwriting TikTok’s game; dispatch setGameInfo on the service matching platform.
Review details

Suppressed comments (2)

app/components-react/windows/go-live/GameSelector.tsx:121

  • This now sends Twitch and Kick selections to TikTokService, so their services no longer receive setGameInfo; instead TikTok's game is overwritten whenever a Twitch or Kick category is selected. Dispatch setGameInfo on the service matching platform as before.
      Services.TikTokService.actions.setGameInfo({
        gameId: game?.value ?? '',
        gameName: game?.label ?? '',
      });
    }

app/services/platforms/tiktok.ts:246

  • This new comment is grammatically incomplete: instead API should be instead of the API.
    // An approved account can still choose to go live with a manually entered
    // stream key instead API, indicated by which tab was active in the form
    if (this.getHasScope('approved') && ttSettings.activeTab === 'live-access') {
  • Files reviewed: 5/5 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

moreIcon={null}
tabBarGutter={0}
subType="filled"
onChange={setActiveTab}
if (this.getHasScope('approved')) {
// An approved account can still choose to go live with a manually entered
// stream key instead API, indicated by which tab was active in the form
if (this.getHasScope('approved') && ttSettings.activeTab === 'live-access') {
@bundlemon

bundlemon Bot commented Sep 17, 2026

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
10.61MB (+794B +0.01%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.67MB -
updater.js
115.29KB -
guest-api.js
40.23KB -

Total files change +794B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants