Tiktok form validation and game persistence. - #6191
Open
michelinewu wants to merge 2 commits into
Open
michelinewu wants to merge 2 commits into
michelinewu wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A critical game-routing defect and moderate tab/credential-path issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates TikTok Go Live settings to persist game selections and validate manual stream credentials based on the active tab.
Changes:
- Tracks TikTok tabs and persists game IDs and names.
- Adds conditional manual credential validation and localized messaging.
- Updates platform game-selection handling.
File summaries
| File | Summary | Final review comment |
|---|---|---|
app/services/platforms/tiktok.ts |
Handles tab-specific streaming behavior and game persistence. | Moderate (3 votes): Undefined activeTab can skip startStream and proceed with empty credentials; treat non-stream-key values as the Live Access path. Nit (1 vote): Correct “instead API” to “instead of the API.” |
app/i18n/en-US/tiktok.json |
Adds the credential validation message. | No final review comment. |
app/components-react/windows/go-live/useGoLiveSettings.ts |
Validates manual TikTok credentials when required. | No final review comment. |
app/components-react/windows/go-live/platforms/TiktokEditStreamInfo.tsx |
Tracks tabs and conditionally requires credential fields. | Moderate (2 votes): Make Tabs controlled from p.value.activeTab so the displayed tab matches validation and beforeGoLive. |
app/components-react/windows/go-live/GameSelector.tsx |
Updates platform game information. | Critical (3 votes): Twitch and Kick selections are sent to TikTokService, overwriting TikTok’s game; dispatch setGameInfo on the service matching platform. |
Review details
Suppressed comments (2)
app/components-react/windows/go-live/GameSelector.tsx:121
- This now sends Twitch and Kick selections to
TikTokService, so their services no longer receivesetGameInfo; instead TikTok's game is overwritten whenever a Twitch or Kick category is selected. DispatchsetGameInfoon the service matchingplatformas before.
Services.TikTokService.actions.setGameInfo({
gameId: game?.value ?? '',
gameName: game?.label ?? '',
});
}
app/services/platforms/tiktok.ts:246
- This new comment is grammatically incomplete:
instead APIshould beinstead of the API.
// An approved account can still choose to go live with a manually entered
// stream key instead API, indicated by which tab was active in the form
if (this.getHasScope('approved') && ttSettings.activeTab === 'live-access') {
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| moreIcon={null} | ||
| tabBarGutter={0} | ||
| subType="filled" | ||
| onChange={setActiveTab} |
| if (this.getHasScope('approved')) { | ||
| // An approved account can still choose to go live with a manually entered | ||
| // stream key instead API, indicated by which tab was active in the form | ||
| if (this.getHasScope('approved') && ttSettings.activeTab === 'live-access') { |
BundleMonFiles updated (1)
Unchanged files (3)
Total files change +794B 0% Final result: ✅ View report in BundleMon website ➡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist the TikTok Game Selection and Require Stream Key Credentials When the Manual Form Is in Use
Fixes for the TikTok edit stream settings form.
Issues
The TikTok game did not survive a platform-settings refresh.
An approved TikTok account on the stream-key tab was never validated.
Fixes
Performance Implications
None.