Repository navigation
Conversation
Alternate-form compound retries now run only when case is ignored, the dictionary is not case-sensitive, or the whole word is upper case. Mixed-case words are judged from the spelling as written, while an all-caps word such as ERRORCODE can still match through its lower-case form. A dictionary test covers the mixed-case rejections and the all-caps, lower-case, and ignore-case cases that still pass. Fixes streetsidesoftware#9452
Resolve the import conflict in SpellingDictionaryFromTrie.ts: main moved repMap out of this file, so only the isUpperCase import is kept.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
With legacy compound splitting and case-sensitive checking, a word whose capitals are wrong is still accepted when the lower-case spelling splits into dictionary words. A form such as eRRorcODE is treated as correct because it is reduced to error plus code.
After the word as written fails the compound lookup, the search is repeated on alternate forms, including the lower-case form. That second pass no longer has the capitals from the original word, so any mixed-case spelling whose lower-case pieces are in the dictionary is accepted.
Summary
Alternate-form compound retries now run only when case is ignored, the dictionary is not case-sensitive, or the whole word is upper case. Mixed-case words are judged from the spelling as written, while an all-caps word such as ERRORCODE can still match through its lower-case form. A dictionary test covers the mixed-case rejections and the all-caps, lower-case, and ignore-case cases that still pass.
How it was tested
packages/cspell-dictionary/src/SpellingDictionary/SpellingDictionary.test.tsfail without the fix in the cspell SpellingDictionaryFromTrie change (checked by reverting the source changes).Fixes #9452