Repository navigation
ci: Fix the publish workflow's dirty tree failure and block workflow calls - #9561
Merged
Merged
Conversation
Merged
6 of 10 tasks
|
@Jason3S I'm adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v10.4.1 publish failed with
EUNCOMMIT. The "Update Sponsor for NPM" step changes tracked files just before publishing. lerna-lite 5.7.0 now enforces its clean working tree check (lerna-lite#1440), which earlier versions never ran.main.--git-headwith the tagged commit, resolved right after checkout, so npm doesn't record the sponsor commit that is lost when the job ends.taginput to the manual run ofpublish.yml. Running from the tag is preferred. The input is for runs started from another ref, such as a retry when the tag's own workflow file is broken.v*tag is checked out, so a manual run can't publish a branch under an unpublished version.workflow_callfrompublish.yml, so another workflow can't call it. The commented-out caller inbuild-version-release.ymlgoes too.PUBLISH_NPMtobuild-version-release.yml, and remove itsid-token: writepermission. It no longer publishes, so onlypublish.ymlreceives the npm token and the OIDC permission.publish.yml:from-packagecreates no commit or tag.The workflow hasn't run yet. In a clone at
v10.4.1, the tag check passed, the commit cleared the dirty state fromgit describe --dirty, which is what the check reads, and the commit resolved after checkout was the tagged commit. The tag check failed on an untagged commit.