Repository navigation
feat(messages): add the uncompressed data size to QueryOk - #228
Merged
Merged
Conversation
The portal needs the size of a result before compression, and it should not have to decompress the data to get it. The field stays out of the signature, so portals that predate it still verify results that carry it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optional uint64 uncompressed_data_size = 4toQueryOk: the size ofdatabefore compression. A portal can now get the raw size of a result without decompressing it.Wire compatibility:
uncompressed_size_is_outside_signature, pins this.optional, so a portal can tell a worker that does not send it from an empty result.QueryOk.QueryFinished::newkeepsdata.len()forQueryOkSummary.uncompressed_data_size. Switching it to the new field is a separate change.Rust API:
QueryOkgains a field, so struct literals need it (or..Default::default()).🤖 Generated with Claude Code