Repository navigation
fix(auth): import an implicit deeplink session before calling onSessionSuccess - #1450
Open
AndroidPoet wants to merge 1 commit into
Open
AndroidPoet wants to merge 1 commit into
AndroidPoet wants to merge 1 commit into
Conversation
jan-tennert
previously approved these changes
Nov 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part of #1105 (the Apple half).
With the implicit flow,
handleDeeplinkscallsonSessionSuccessbefore the session is imported.parseFragmentAndImportSessioncallsonFinishand only thenimportSession, so inside the callbackcurrentSessionOrNull()is stillnullandsessionStatusis not yetAuthenticated. An app that navigates or reads the session inonSessionSuccesssees no session. The PKCE flow already imports first and then calls the callback. This affects both the Android and the ApplehandleDeeplinks.Fix
Call
importSessionbeforeonFinishinparseFragmentAndImportSession.Tests
New
Auth/src/appleTest/kotlin/HandleDeeplinksTest.apple.ktdrives the ApplehandleDeeplinks(NSURL)against the mocked client:/token?grant_type=pkce, and the session is stored whenonSessionSuccessruns.onErrorgets theIllegalArgumentExceptionand no session is stored.error,error_codeanderror_descriptionin the URL: anAuthEvent.OtpErroris emitted and no request is sent./user, and is current whenonSessionSuccessruns. This one fails without the fix.All 201 Auth macosArm64 tests and 196 Auth JVM tests pass, and detekt is clean. The Android half of #1105 needs Robolectric, so it is not in this PR.
No public API change.