fix(ui): reset the CopyButton checkmark after each copy#1282
Open
abhay-codes07 wants to merge 1 commit into
Open
fix(ui): reset the CopyButton checkmark after each copy#1282abhay-codes07 wants to merge 1 commit into
abhay-codes07 wants to merge 1 commit into
Conversation
The reset timer ran once on mount with an empty dependency array, so it fired two seconds after render, before any click, and nothing ever set hasCopied back to false afterwards. The first copy swapped the clipboard icon to a checkmark permanently and later copies gave no visual feedback. Key the effect on hasCopied with a cleanup, the same pattern copyable-cell.tsx already uses: every copy shows the checkmark for two seconds and reverts, rapid re-copies restart the window, and the stray mount-time timer is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
CopyButtoncheckmark never resets. The reset timer runs once on mount with an empty dependency array — i.e. it fires (uselessly) two seconds after render, before any click — and nothing ever setshasCopiedback tofalseafter a copy:In the integrations install-steps (the component's consumer), the first copy click swaps the clipboard icon to a checkmark permanently; subsequent copies give no visual feedback at all.
Fix
Key the effect on
hasCopiedwith proper cleanup — the same pattern the siblingcopyable-cell.tsxalready uses:Each copy now shows the checkmark for 2 seconds and reverts; rapid re-copies restart the window cleanly, and the stray mount-time timer is gone.
Testing
bun run buildinapps/web(the consumer) — cleanbiome checkon the touched file — clean