Add custom React views to workflow runs - #7
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68b49aa7f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a8f155dad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcb09225a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af869ef4a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73dab300a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <span> | ||
| {presentation.asset.id} · revision {presentation.asset.revision} | ||
| </span> | ||
| <button type="button" onClick={() => setStatus("disabled")}> |
There was a problem hiding this comment.
Close the frame channel when disabling the custom view
When a user disables a loading or ready view, this only changes React state; it does not invalidate initialization, clear readyTimer, or close the MessageChannel. Consequently, a loading view's timeout can later set the status to error and remount the iframe without user action, while an input view that already received its port can continue sending candidates after being disabled. Route this action through the same channel/timer cleanup used for identity changes before setting disabled.
Useful? React with 👍 / 👎.
Summary
.ui.tsxauthoring APIs for input views and replayable result viewsexamples/09-custom-react-uiworkflow covering result views, custom human input, and a composed final presentation, plus a key-feature coverage matrix for all examplesEngine.pending()reconstructs root or descendant requests after restartImportant behavior
ctx.ui.render()is a separate replayable step, so visual presentations do not invalidate their producing computationValidation
pnpm lintpnpm typecheckpnpm buildpnpm verify:examples(67 public workflow surfaces mapped)npx tsx examples/09-custom-react-ui/main.ts(offline compile, suspend, answer, replayable presentations)Browser verification
The implementation has daemon-frame and Workflow Manager integration coverage, but this environment did not expose the persistent JavaScript REPL required for a real Playwright painted-browser pass. The implementation article explicitly keeps the Chromium/Firefox/WebKit isolation and visual matrix as a pre-production verification requirement rather than claiming it was completed here.