Repository navigation
refactor(http): make Request::$uri into a Uri object - #2311
NeoIsRecursive wants to merge 3 commits into
Conversation
|
Sorry for the ping @innocenzi, just wanted to ask if you think this is the way to go here? (the changes to And i'm not sure about how the Connect requests should work (failing test), havent encountered one of those before :3 |
|
Yeah, I think the change to the
I'd say no, the interface is noisy and uses getter methods instead of properties
Naming is hard, come up with your best 😅
Probably at some point, but if we don't have the need right now, I'd say let's not bother |
I wanted to draft something before doing more.
Some thoughts I have got so far:
:///test-redirect-back-url#), would there be any issuea falling back toBASE_URI?I never remember the difference between Url and Uri so might have some terminology wrong, sorry if that is the case :P (did some reading, and perhaps adding an URL class might be better since that forces a scheme etc. uri might be to generic here, not sure)
Closes #2307