Repository navigation
Update sdk-core to main (WFT buffering fix) - #948
Merged
Merged
Conversation
Ran core:update, relocked the bridge, and confirmed the mirrored workspace tables still match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in temporalio/sdk-rust#1640. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
THardy98
changed the title
Core's range includes an API update (temporalio/sdk-rust#1652). Ran gen:api and gen:nexus with the pinned protoc 23.4 and nexgen 0.2.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
THardy98
marked this pull request as ready for review
October 15, 2026 00:57
jmaeagle99
approved these changes
Oct 15, 2026
| @@ -0,0 +1 @@ | |||
| Replay detects changes to the service or operation of scheduled Nexus operations, reporting nondeterminism while retaining compatibility with histories recorded before these checks. | |||
Contributor
There was a problem hiding this comment.
Each of these change log entries should start with "Core: ". This probably didn't happen with some of these entries because the tooling updated between updates. But let's make it consistent with this update.
Contributor
Author
There was a problem hiding this comment.
Done in 13ba4e3, all entries now start with "Core: ".
| @@ -0,0 +1,3 @@ | |||
| Worker heartbeats now report correct task-slot and poller counts when using buffered or custom metrics backends, including the Python SDK's `MetricBuffer`. Previously these counts could remain `0` because heartbeat accounting depended on reading labels from backend-owned attributes. | |||
Contributor
There was a problem hiding this comment.
I know you didn't write this entry, but we probably shouldn't include ", including the Python SDK's MetricBuffer" in any of the SDKs change logs (except for maybe Python). Maybe reword it as ".NET SDK's CustomMetricMeter".
Contributor
Author
There was a problem hiding this comment.
Done in 13ba4e3, reworded to the .NET SDK's CustomMetricMeter.
Prefix all Core changelog entries with "Core: " and replace the Python-specific MetricBuffer reference with the .NET CustomMetricMeter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Updates the sdk-core submodule from
8fe478ee(Core 1.1.0) to212e8150, Core's currentmain, which includes temporalio/sdk-rust#1640. Done withmise run core:update, which imported Core's changelog entries as fragments. BridgeCargo.lockis relocked (one line). The mirrored workspace tables are unchanged (bridge:check-syncpasses). Core's range includes an API update (temporalio/sdk-rust#1652), so theTemporalio.Apitypes and the System Nexus payload visitor are regenerated (gen:api,gen:nexus, with the pinned protoc 23.4 and nexgen 0.2.4). The C header is unchanged, so there's no interop regeneration.Why?
To fix .NET workers losing workflow tasks under load. At 40 concurrent throughput_stress workflows, .NET on Core 1.1.0 logged "Trying to send a new WFT for a run which already has one!" about 100 times per hour-long run. The lost workflow tasks then hit nondeterminism errors, and the workflows got stuck.
Checklist
Closes
How was this tested:
cargo build --lockedinsrc/Temporalio/Bridge).dotnet build src/Temporaliosucceeds with the regenerated code.Any docs updates needed?
No.