[SDK Sentinel] Allow delayed activity visibility in pause test - #1916
Open
sdk-sentinel-bot wants to merge 1 commit into
Conversation
tconley1428
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Prevent a load-sensitive false failure in the activity pause/unpause test. The [first captured failing main run](https://github.com/temporalio/sdk-python/actions/runs/36917506838) missed the activity, while a [subsequent successful main run](https://github.com/temporalio/sdk-python/actions/runs/36925546375) passed after an unrelated change.
Root cause
The test allowed five seconds for its initial activity to appear in server state. Source logs show that deadline expiring just as the activity started and worker shutdown began, so the assertion observed a transient absence.
Fix
Use a ten-second eventual-observation budget at this test's initial pending-activity handshake. This preserves the state assertion and does not retry the test.
Validation
Three unchanged and three changed focused Linux runs passed. The unchanged baseline and fixed repository validator passed. macOS Python 3.10 CI remains required because the natural delay was not reproduced locally.
Validation status:
ci-validation-requiredhighmediummediumstandard— 1 changed file; 676 Bnot-reproduced— Three unchanged focused Linux attempts passed; macOS Python 3.10 was unavailable locally.pass-after-only— The existing focused test passed three times after the isolated timing-budget change; no new test was added for this test-only correction.Poe lint, bridge lint, and editable build) — passedPoe lint, bridge lint, and editable build) — passedInvestigator-run checks
for attempt in 1 2 3; do poe test -s -k test_activity_pause_unpause \|\| exit; done— passed; 3 attempt(s). All three post-change Linux Python 3.14 attempts passed; three unchanged attempts also passed..ci-flake-runtime/input/validate.sh— passed; 1 attempt(s). Canonical formatting, typing, documentation, Rust lint, and editable-build validation passed; the trusted unchanged baseline also passed.Required target CI
Residual risks
Automation provenance
03cdb189e7c05c7f37ff7818f589d1dfbc1b4b6aIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-10-01 20:10 UTC2026-10-01 20:10 UTC