Skip to content

[SDK Sentinel] Allow delayed activity visibility in pause test - #1916

Open
sdk-sentinel-bot wants to merge 1 commit into
temporalio:mainfrom
sdk-sentinel-forks:automation/sdk-sentinel/ci-flake/python/36944416617-1-18e9e4f49a1b
Open

sdk-sentinel-bot wants to merge 1 commit into
temporalio:mainfrom
sdk-sentinel-forks:automation/sdk-sentinel/ci-flake/python/36944416617-1-18e9e4f49a1b

Conversation

@sdk-sentinel-bot

Copy link
Copy Markdown
Contributor

Caution

This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.

Summary

Prevent a load-sensitive false failure in the activity pause/unpause test. The [first captured failing main run](https://github.com/temporalio/sdk-python/actions/runs/36917506838) missed the activity, while a [subsequent successful main run](https://github.com/temporalio/sdk-python/actions/runs/36925546375) passed after an unrelated change.

Root cause

The test allowed five seconds for its initial activity to appear in server state. Source logs show that deadline expiring just as the activity started and worker shutdown began, so the assertion observed a transient absence.

Fix

Use a ten-second eventual-observation budget at this test's initial pending-activity handshake. This preserves the state assertion and does not retry the test.

Validation

Three unchanged and three changed focused Linux runs passed. The unchanged baseline and fixed repository validator passed. macOS Python 3.10 CI remains required because the natural delay was not reproduced locally.

Validation status: ci-validation-required

  • Flake confidence: high
  • Fix confidence: medium
  • Value: medium
  • Patch scope: standard — 1 changed file; 676 B
  • Local reproduction: not-reproduced — Three unchanged focused Linux attempts passed; macOS Python 3.10 was unavailable locally.
  • Regression coverage: pass-after-only — The existing focused test passed three times after the isolated timing-budget change; no new test was added for this test-only correction.
  • Unchanged baseline (Poe lint, bridge lint, and editable build) — passed
  • Independent candidate (Poe lint, bridge lint, and editable build) — passed

Investigator-run checks

  • for attempt in 1 2 3; do poe test -s -k test_activity_pause_unpause \|\| exit; done — passed; 3 attempt(s). All three post-change Linux Python 3.14 attempts passed; three unchanged attempts also passed.
  • .ci-flake-runtime/input/validate.sh — passed; 1 attempt(s). Canonical formatting, typing, documentation, Rust lint, and editable-build validation passed; the trusted unchanged baseline also passed.

Required target CI

  • Continuous Integration / build-lint-test (3.10, macos-arm)

Residual risks

  • Linux did not reproduce the captured scheduling delay.
  • The ten-second budget provides measured headroom but cannot bound every possible runner stall.

Automation provenance

If this finding should not be fixed, apply the sdk-sentinel:false-positive label and close the PR. Sentinel will suppress the finding until its affected source changes.

SDK Sentinel recurrence history

  • Unique failed CI run attempts: 1
  • First occurrence: 2026-10-01 20:10 UTC
  • Latest occurrence: 2026-10-01 20:10 UTC
  • Recent occurrences:

@sdk-sentinel-bot
sdk-sentinel-bot requested a review from a team as a code owner October 2, 2026 00:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants