Cosmetic change in the Scrollbar code - #388
Merged
Merged
Conversation
Now Scrollbar checks if it's hovered like it's done by Slider.
Removed previous changes; now using a different approach to drawing the Scrollbar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the Scrollbar would look a bit better if it were drawn as hovered, even if the mouse is outside it, as it is with the Slider now, so I made a small change to Scrollbar.cpp. The code is not identical to that of Slider: changes affect only the Scrollbar::draw(...) method. It seems like these changes don't break anything (I have checked the behavior of an example program manually). I hope it can be useful.