Repository navigation
Conversation
… settings to Chinese - Add static LocalizationService.T() and GetString(key, args) overload for formatted resource lookup without DI - Replace ~200 hardcoded user-facing strings in MainBlazorUI, MonitorMessage, MessageLog, TimersManager, Sound, UpdateCoordinator, and UpdateApplier with resource keys (new zh translations, 89 keys) - Inject LocalizationService into the 7 TarkovTracker dialogs and localize Settings.razor tracker cards, dialog titles, and messages (118 keys) - Fill 4 pre-existing zh gaps (Connect, LastProfileLoaded, NoActiveEftSessionRecognized, WebsiteAlreadyConnectedMsg) - Adopt 匆匆撤离 as the translation for Run-through per glossary decision - Add docs/translation-glossary.md documenting terminology and style rules
过滤吸收器 was a literal mistranslation; 中文攻略站通行叫法为空气过滤器 (the consumable for the hideout Vents station). Update the 3 affected keys and record the decision in docs/translation-glossary.md.
…e messages Phase 3 - remaining Blazor surfaces (48 keys): AppLayout window controls and floating timer panel, Sounds media controls and file dialogs, Timers status chip, RawLogs dialogs, CustomLogDialog, ForceReadDialog flow messages, LogBoard/MessageBoard empty states and protected-value labels Phase 4 - service layer user-visible messages (68 keys): TarkovTracker storage warnings and token validation/import/bind/unbind exceptions, TarkovTrackerOrgStore operation and corruption messages, TokenStoreProtection decrypt failure. Static classes use LocalizationService.T() Verified: EN/ZH key parity 510=510, placeholder sets match on every key, all 484 code-referenced keys present, Release build clean, startup smoke test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #232 (proposal). This PR completes the Simplified Chinese localization across the whole application, building on the existing zh resources (~96 of 103 keys).
What changed
zh resources grew from 99 to 509 keys. All new keys have EN (neutral) and ZH values; the other five locales are untouched and fall back to English.
MainBlazorUI,MonitorMessage,MessageLog,TimersManager,Sound,UpdateCoordinator,UpdateApplier): message-board notifications (raid lifecycle, flea market, task tracking, Goons reports), exception-card text, confirmation dialogs, and the in-app update flowTarkovTracker,TarkovTrackerOrgStore, andTokenStoreProtection(storage warnings, token validation/import/bind/unbind errors). Deep diagnostics that only appear in the copied diagnostics clipboard remain English on purposedocs/translation-glossary.md: terminology decisions for future translators (e.g. Run-through → 匆匆撤离, air filter → 空气过滤器; PMC/Scav/Goons/brand names stay English)Design notes
LocalizationService.GetString(key, params args)overload and a staticLocalizationService.T()helper, because static classes (TarkovTracker,TarkovTrackerOrgStore,MessageLog) cannot take DI. Happy to change this if you prefer another patternmaster(4100619); the obsolete minimize-at-startup warning message removed upstream in14de046was dropped from both resources accordinglyVerification
One small behavioral note: the Read Past Logs task messages now reuse the existing
TaskStarted/TaskFailed/TaskCompletedresources instead of a separate "Failed task: X." string, which also consolidates the English wording with the live task notifications.