Skip to content

fix: make observe cleanup idempotent#763

Merged
thebuilder merged 1 commit into
mainfrom
feat/004-idempotent-observe-cleanup
Jul 14, 2026
Merged

fix: make observe cleanup idempotent#763
thebuilder merged 1 commit into
mainfrom
feat/004-idempotent-observe-cleanup

Conversation

@thebuilder

Copy link
Copy Markdown
Owner

Summary

  • make every cleanup returned by observe() safe to call repeatedly
  • prevent repeated cleanup from removing another callback sharing the same observer
  • cover shared-subscriber delivery and final observer teardown with a regression test

Fixes #757.

Verification

  • corepack pnpm exec vitest run src/__tests__/observe.test.ts
  • corepack pnpm exec vitest run
  • corepack pnpm exec tsc --noEmit
  • corepack pnpm exec biome check src/observe.ts src/__tests__/observe.test.ts
  • corepack pnpm build

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-intersection-observer Ready Ready Preview, Comment Jul 14, 2026 11:13am

@pkg-pr-new

pkg-pr-new Bot commented Jul 14, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/react-intersection-observer@763

commit: 6ff366b

@thebuilder thebuilder marked this pull request as ready for review July 14, 2026 11:16
@thebuilder thebuilder merged commit 8c71bd4 into main Jul 14, 2026
9 checks passed
@thebuilder thebuilder deleted the feat/004-idempotent-observe-cleanup branch July 14, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make observe() cleanup idempotent

1 participant