Conversation
detiber
force-pushed
the
namespacesWIP
branch
2 times, most recently
from
September 29, 2020 19:23
c3adef8 to
6d4d129
Compare
detiber
force-pushed
the
namespacesWIP
branch
from
September 29, 2020 19:32
6d4d129 to
fd3aece
Compare
Member
Author
|
Upstream defaulter-gen doesn't support referencing external types, PR to add that support is here: kubernetes/gengo#185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3
This appears to be mostly complete, there is still an error when attempting to start the Namespace controller that needs to be sorted out.
This also needs to be cleaned up to remove copied code that is not used and other potential cleanups prior to merging.