ci: strengthen documentation validation pipeline - #184
Open
jankiluitel wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for thoth-tech ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Rhinoatron
approved these changes
Sep 4, 2026
Rhinoatron
left a comment
There was a problem hiding this comment.
Amazing work. The CI changes look focused and useful. Updating the GitHub Actions versions, switching to npm ci, adding npm caching, and keeping the existing Linelint, Prettier, and Vale checks all make sense. Adding npm run build is also a good improvement because it validates the actual Astro/MDX documentation build and can catch issues that formatting or prose checks would miss. I also checked for overlap with other PRs and did not find another current PR making this same CI/build-validation change. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR strengthens the existing CI pipeline for the ThothTech Documentation Website by modernising GitHub Actions and adding automated production-build validation.
Changes
actions/checkoutfrom v2 to v4.actions/setup-nodefrom v1 to v4.npm installwithnpm cifor reproducible CI installations.npm run buildto validate Astro/MDX compilation and internal links.Motivation
The existing CI pipeline validates formatting and prose quality but does not run the Astro production build.
This means documentation changes could potentially pass CI while still containing build errors, invalid MDX, or broken internal links.
Adding the production build provides an additional automated quality gate for documentation contributions, including the SplashKit documentation workflow.
Testing
npm cicompleted successfully.npm run format:checkpassed.npm run buildcompleted successfully.