TINY-12772: Add new katamari type suggestion rule - #54
Open
ltrouton wants to merge 5 commits into
Open
Conversation
ltrouton
requested review from
a team,
MitchC1999,
TheSpyder,
jscasca and
tiny-ben-tran
and removed request for
a team
August 27, 2025 04:10
Contributor
Author
|
Use of rule in tinymce repo: tinymce/tinymce#10558 |
spocke
approved these changes
Sep 8, 2025
spocke
left a comment
Member
There was a problem hiding this comment.
Can we also detect truthy checks I guess that needs type information? I assume this will create a lot of errors on the old tinymce code base. But we can just turn of the rule or make a monster PR to fix it.
Contributor
Author
|
I am thinking of handling falsy and truthy checks using native typescript eslint rules:
I need to look into this more again |
MitchC1999
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-12772
Description of Changes:
undefinedandnullchecksPre-checks: