Conversation
Owner
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPXTrackSegment.length_2d()delegates togeo.length_2d(), which always returns a number, including zero for empty or single-point segments. ItsOptional[float]annotation nevertheless prevents callers from using that result as afloatwithout a None check. Change it tofloat, matching the implementation and the track/GPX length methods.Fixes #286.
The regression test uses explicitly typed assignments for empty, single-point, and two-point segments, and checks the returned distances. All three assignments fail mypy before the annotation fix and pass afterward.
Validation on Python 3.13.5:
gpxinforuns successfully on all GPX fixtures;git diff --checkpasses.Prepared and tested using OpenAI Codex; no human review is claimed.