-
Notifications
You must be signed in to change notification settings - Fork 7
Ogre v14.6 v3 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: shaders-improvement
Are you sure you want to change the base?
Ogre v14.6 v3 #15
Changes from all commits
2dfeb85
e010f99
54f9930
70676f1
3879605
f55753e
79fe093
550f41c
bb4a72a
aca1c91
85a4173
a4bb2b5
e450a9c
7c161d7
6420d3c
bb523dc
27a6a9b
34c9d07
816f452
de1cba2
f604940
7b17512
99f44bf
3944e4d
efa47d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| [Graphics] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The six hardcoded
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed that with followup commit as latest Ogre update showed the problem. |
||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib | ||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib/GLSL | ||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib/HLSL | ||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib/HLSL_Cg | ||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib/materials | ||
| FileSystem=@CMAKE_INSTALL_PREFIX@/share/OGRE/Media/RTShaderLib/../Main | ||
| # Our hand-written .vert/.frag live in the Graphics group and #include | ||
| # OgreUnifiedShader.h plus the RTShaderLib FFPLib_*/SGXLib_* sources. Ogre resolves | ||
| # those includes within the *same* resource group, so Main must be here. | ||
| # RTShaderLib is deliberately listed ONLY here: adding it to [OgreInternal] as well | ||
| # makes RTSSamplers.material parse twice and Ogre then throws | ||
| # "Sampler 'Ogre/ShadowSampler' already exists" during startup. | ||
| # Likewise, Media/Main must NOT also be in [OgreInternal] because Shadow.material | ||
| # defines shared_params OgreFroxels which would be created twice. | ||
| FileSystem=@RTSHADER_DIR@ | ||
| FileSystem=@OGRE_MEDIA_DIR@/Main | ||
| FileSystem=materials/scripts | ||
| FileSystem=materials/scripts/Creatures | ||
| FileSystem=materials/textures | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now competes with the existing mechanism rather than replacing it. Line 213 still does:
where
OD_CXX11_FLAGSis-std=c++11from theCHECK_CXX_COMPILER_FLAGprobe above. Both-std=c++11and-std=gnu++14end up on the command line, and which one wins is down to CMake's argument ordering.Also missing
set(CMAKE_CXX_STANDARD_REQUIRED ON)— without it CMake silently falls back to an older standard on a compiler that can't do C++14, rather than failing the configure.Cleanest is to drop the
OD_CXX11_FLAGSprobe entirely (lines 144-154) and letCMAKE_CXX_STANDARDown this.CMAKE_CXX_EXTENSIONSdefaults toON, which gives-std=gnu++14and covers the MinGW case the old probe was working around.