Conversation
This was referenced Sep 5, 2026
Rokk001
marked this pull request as ready for review
September 5, 2026 23:15
Embed per-monitor DPI awareness and maintain the verified OGRE 13.6.5 renderer patch required for context-safe window replacement, runtime GL options and correct fullscreen client geometry. Validation: clean Release build, DPI and 3440x1440 fullscreen probes, three GL3Plus variants and the patch reverse check passed; version 0.7.1 remains unchanged because this is unreleased work and the project has no changelog.
Apply display, input, audio, gameplay, minimap, shadow and negotiated nickname changes to the running session while preserving rollback for failed window or input transitions and keeping the 3440x1440 navigation visible. Validation: clean Release and Debug builds, packet tests, DPI, layout and GL3Plus probes passed; the user confirmed the reported resolution, fullscreen, cursor, flicker and navigation failures are fixed. Version 0.7.1 remains unchanged because this is unreleased work and the project has no changelog.
Rokk001
force-pushed
the
feature/live-settings
branch
from
September 6, 2026 23:12
fc1cfe6 to
a9ef80e
Compare
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving display settings previously required a restart or could leave the render window, input coordinates and viewports out of sync.
Change
Coordination
Depends on #47 and #49. This partially addresses the windowed pointer mismatch in issue #6 but does not close its broader interface report; PR #15 changes the renderer baseline and overlaps this path.
Verification
The user accepted live resolution and fullscreen changes, corrected pointer alignment and removal of the bottom-edge flicker. Focused renderer and packet checks passed during development, and the reconstructed stack through #53 completed a clean Windows x64 Release build. Other platforms, multiple monitors and mixed-version multiplayer remain unverified.
Review only the live-settings changes