Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a saved single-player game could reopen the new-game seat-selection
lobby, and the Load command was disabled during play. Reuse the saved-game
browser over the active local game, preserve that game and its pause state on
Back, and defer replacement until a save has been selected. Fixed single-human
saves resume their stored side through the existing protocol.
The same browser keeps long descriptions accessible through a usable scrollbar,
resets the scroll position when selection changes and clears stale descriptions
on reopening. Its required scrollbar skin is included; the broader menu redesign
is not a dependency of this contribution. The existing save format is unchanged.
Depends on #80 for Escape/back dispatch. The default comparison includes that
prerequisite; review this contribution alone.
The separate room-lighting teardown correction remains in #81. No matching open
issue was identified for this complete loading/browser outcome.
Validation: a Windows x64 Release integration build with #47/#53 and the other independently scoped contributions passed, as did runtime preparation; this is not a standalone cross-platform build claim. The production browser with real CEGUI events passed 176 checks, including scrolling and reset; existing protocol/seat setup passed 201 checks and deferred mode transitions passed 18. The user previously accepted loading during play and description access in the complete fork. No game was launched for this assembly; other-platform runtime and complete save-format fidelity remain outside this verification.