Polish login screen layout and sign-in buttons - #30
Merged
Conversation
- Vertically center sign-in buttons with 24px padding and 16px gap; fixes Apple button rendering at natural size and clipping at viewport - Size both brand image buttons to 50px height with contain fit (no distortion/clipping); put Apple button on a neutral themed card so it looks intentional in dark mode - Add muted tagline under the logo - Developer Options already gated behind __DEV__; auth logic unchanged
Use single white button image for both modes instead of separate dark/light PNGs. The dark mode image had a visible rounded rectangle border that looked bad on dark backgrounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visual/layout-only polish of the login screen (
front/app/login.tsx,front/components/GoogleSignInButton.tsx,front/components/AppleSignInButton.tsx). No auth logic changed — OAuth flows, token handling, and deep linking are identical.containfit — no distortion or clipping. The Apple button now uses the standard white button image for both light and dark modes, eliminating the dark mode border artifact.apple-sign-in-dark.png) had a visible rounded rectangle border that looked bad on dark backgrounds. Replaced with a single white button image for both modes — clean in both contexts.__DEV__in the source; that gate is preserved intact.Verified with
npm run lint(0 errors) and jest (28 passed; the_layout-test.tsxsuite failure is pre-existing onorigin/mainand unrelated).Screenshots (390x844, light & dark)
Light
Dark