Repository navigation
Reject a truncated iNES header instead of parsing past its end - #3607
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_ines_headerchecks the magic and then readsheader[4]throughheader[10]and slicesheader[11:], butparse_inesgets the header fromfile_stream.read(16), which returns short on a truncated file. Only the magic is validated, so a 4 byte file gets through.On a ROM cut to 4 bytes,
polyfile --format jsonlogsParser parse_ines ... raised an exception while parsing: index out of range, exits 0, and still emits aniNESHeaderelement with"size": 16for a 4 byte file, with everything after the magic missing. A consumer of that JSON sees a partial structure and a length that cannot be right.Lengths 11 to 15 are worse in a way, since nothing raises at all:
header[11:]just returns short, so the output carries a 16 byteiNESHeaderand an undersizedUnusedPaddingwith no warning anywhere.Raising
InvalidMatchmatches how the bad-magic case is already handled, and the dispatcher treats it as a clean non-match rather than an internal error. A well-formed ROM is unaffected, and I confirmed the full structure still comes out for one.The new tests cover lengths 4 to 15; all twelve fail on master.
tests/unitis 81 passing.