Skip to content

dependabot: Fix yq ignore - #390

Merged
Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:ignore-dependabot-v4
Oct 21, 2026
Merged

Jakob-Naucke merged 1 commit into
trusted-execution-clusters:mainfrom
Jakob-Naucke:ignore-dependabot-v4

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

must ignore .../yq/v4, not .../yq. Until we have Go 1.26 in all appropriate CIs & downstreams. Closes #389.

Summary by Sourcery

Bug Fixes:

  • Correct the Dependabot ignore rule to target the versioned yq/v4 module until Go 1.26 support is available across CI and downstreams.

must ignore .../yq/v4, not .../yq. Until we have Go 1.26 in all
appropriate CIs & downstreams. Closes trusted-execution-clusters#389.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Dependabot ignore configuration so yq v4 releases at or above 4.54 remain ignored until Go 1.26 support is available across CI and downstream consumers.

File-Level Changes

Change Details Files
Correct the Dependabot ignore rule to target the versioned yq module path.
  • Change the ignored dependency name from the unversioned module path to github.com/mikefarah/yq/v4 while retaining the >=4.54 version constraint.
.github/dependabot.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@openshift-ci

openshift-ci Bot commented Oct 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jakob-Naucke, SpaceFace02

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Oct 21, 2026
@Jakob-Naucke
Jakob-Naucke merged commit a4e2bd8 into trusted-execution-clusters:main Oct 21, 2026
13 of 14 checks passed
@Jakob-Naucke
Jakob-Naucke deleted the ignore-dependabot-v4 branch October 21, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants