Fail notification streams when the connection is lost#1323
Open
rpiaggio wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session#channel(...).listen(...)(andProtocol#notifications) hanged silently forever if the session's connection dies.The cause was in
BufferedMessageSocket: the background read loop's failure handler only offered aNetworkErrorpoison pill to the synchronous message queue, which raised on the nextsend/receiveexchange. A LISTEN-only session never performs another exchange, and the notificationsTopicwas neither failed nor closed, so its subscribers waited forever.This was found and fixed by Claude while looking for the root cause of subscribers not reporting changes on a running server and the reinitialization logic not being triggered.