feat: Add instance branching + checkpointing - #403
Draft
jedevc wants to merge 12 commits into
Draft
Conversation
Signed-off-by: Justin Chadwell <justin@unikraft.com>
khatibomar
reviewed
Jul 31, 2026
Signed-off-by: Justin Chadwell <justin@unikraft.com>
Signed-off-by: ayn <ayn.khatib@gmail.com>
Signed-off-by: ayn <ayn.khatib@gmail.com> Signed-off-by: ayn <ayn.khatib@gmail.com> Signed-off-by: ayn <ayn.khatib@gmail.com>
khatibomar
force-pushed
the
jedevc/instance-branching
branch
2 times, most recently
from
July 31, 2026 17:40
384f0e7 to
f78fa9b
Compare
Signed-off-by: ayn <ayn.khatib@gmail.com>
khatibomar
force-pushed
the
jedevc/instance-branching
branch
from
July 31, 2026 17:46
f78fa9b to
a2224e5
Compare
--branch and --checkpoint parsed a metro/name ref but silently dropped the metro part before sending the request to a single metro client, unlike the sibling template/volumes/service handling in the same function. A cross-metro ref could silently target a same-named but wrong resource, or fail with a misleading error. Signed-off-by: ayn <ayn.khatib@gmail.com>
InstanceCheckpoint.Get() matched API response items to requested refs by array position, unlike every sibling Get() which uses matchRef. If the platform reorders or omits entries, a checkpoint's tracked identity (Key()) could get swapped with another's. Signed-off-by: ayn <ayn.khatib@gmail.com>
Create() discarded successfully-created checkpoint keys whenever any sibling instance in the same batch failed, because the outer loop skipped the append on error. This left orphaned, untracked checkpoints on the platform while the CLI reported total failure. Signed-off-by: ayn <ayn.khatib@gmail.com>
getInstanceHistory() skipped only entries with an explicit non-success status, so a nil Status fell through and was treated as successful. Every other status check in this file (and codebase) treats a missing status as failure, not success. Signed-off-by: ayn <ayn.khatib@gmail.com>
--image, --template, --branch, and --checkpoint are mutually exclusive per the SDK docs, but only the roms field enforced a similar pattern. Reject the request when more than one source is set instead of silently letting one win. Signed-off-by: ayn <ayn.khatib@gmail.com>
Signed-off-by: ayn <ayn.khatib@gmail.com> Signed-off-by: ayn <ayn.khatib@gmail.com>
khatibomar
force-pushed
the
jedevc/instance-branching
branch
from
July 31, 2026 19:40
3ec0c39 to
08d8f90
Compare
Signed-off-by: ayn <ayn.khatib@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: