feat(cmd): Accept namespaces for listing - #432
Open
craciunoiuc wants to merge 1 commit into
Open
Conversation
jedevc
reviewed
Jul 29, 2026
jedevc
requested changes
Jul 31, 2026
jedevc
left a comment
jedevc
left a comment
Member
There was a problem hiding this comment.
Still have comments, and also still needs tests.
Contributor
Author
|
yeah, I didn't get to it yet ;_; |
craciunoiuc
force-pushed
the
craciunoiuc/list-images-official
branch
from
July 31, 2026 12:49
8e9019c to
b604bd1
Compare
Contributor
Author
|
comment was addressed (actually nothing to do) tests successfully vibrated |
Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/list-images-official
branch
from
July 31, 2026 12:52
b604bd1 to
43a472e
Compare
Contributor
Author
|
(lemme know if you want a single test for these kind of things, aka the golden path, or trying everything) |
Member
|
Yeah, we should just have this integrated into the rest of the tests - no need to do a new test setup or a custom http server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems straight-forward
Closes: TOOL-760