Skip to content

Addition of ASEA FSS Regions - #1200

Merged
daniluk4000 merged 14 commits into
vatsimnetwork:masterfrom
HacobAllon:master
Oct 1, 2026
Merged

daniluk4000 merged 14 commits into
vatsimnetwork:masterfrom
HacobAllon:master

Conversation

@HacobAllon

@HacobAllon HacobAllon commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

Addition of:
ASEA
ASEA_N
ASEA_E
ASEA_S
ASEA_W

Approved contributor?

  • I am on the approved contributors list
  • I have sent an request by email to get approved
  • Someone on the approved contributor list will review this request

Copilot AI lite review requested due to automatic review settings September 21, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Contributor data:

  • CID: 1504338
  • Name: Jacob Allen
  • Region: VATSEA / Philippines
  • Role: Facilities Director
  • Approving CID: N/A
  • Approving staff: N/A

@daniluk4000

Copy link
Copy Markdown
Collaborator
image

This should be in UIRs and is also in conflict with existing UIRs

@daniluk4000

Copy link
Copy Markdown
Collaborator

That will be enough, you can replace Boundaries.geojson with master branch file, then you can solve conflicts with VATSpy.dat

@HacobAllon

Copy link
Copy Markdown
Contributor Author

Ah brilliant thank you

@daniluk4000

daniluk4000 commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Conflicts are not solved yet, FYI

HacobAllon and others added 2 commits September 25, 2026 12:13
- Boundaries.geojson: take upstream as-is (ASEA regions belong in UIRs, per review).
- VATSpy.dat: split ASEA into N/E/S/W subregions atop upstream's ASEA/ASEA_N/ASEA_S.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@HacobAllon
HacobAllon marked this pull request as draft September 25, 2026 10:14
@daniluk4000
daniluk4000 marked this pull request as ready for review September 25, 2026 10:14
@daniluk4000
daniluk4000 marked this pull request as draft September 25, 2026 10:14
@HacobAllon
HacobAllon marked this pull request as ready for review September 25, 2026 17:33
@daniluk4000

Copy link
Copy Markdown
Collaborator
image You need to re-add this, PR is now empty

@HacobAllon
HacobAllon marked this pull request as draft September 28, 2026 23:47
@daniluk4000

Copy link
Copy Markdown
Collaborator

@HacobAllon is this still a draft?

@HacobAllon

Copy link
Copy Markdown
Contributor Author

If everything is okay then I can remove the draft

@daniluk4000
daniluk4000 marked this pull request as ready for review September 30, 2026 08:17
@daniluk4000
daniluk4000 merged commit 92e89c2 into vatsimnetwork:master Oct 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants