Repository navigation
Conversation
Contributor
Failing test suitesCommit: af04f26 | About building and testing Next.js
Expand output● instant-navigation-testing-api - without Cache Components › does not enable instant navigation
Expand output● middleware-static-rewrite › should handle middleware rewrites as well |
gnoff
force-pushed
the
jstory/deploy-tests/manifest-cleanup
branch
from
August 28, 2026 19:51
6a63949 to
793b075
Compare
gnoff
force-pushed
the
jstory/deploy-tests/skip-rationales
branch
from
August 28, 2026 19:51
fb4f051 to
52702e6
Compare
gnoff
force-pushed
the
jstory/deploy-tests/manifest-cleanup
branch
from
August 28, 2026 23:33
793b075 to
a8e42e4
Compare
gnoff
force-pushed
the
jstory/deploy-tests/skip-rationales
branch
from
August 28, 2026 23:33
52702e6 to
6b6b464
Compare
## Summary Make suite-level deploy-test exclusions explicit and searchable across the e2e test suite. - Add `Deploy mode exclusion:` comments for exclusions tied to local processes, local files or build artifacts, and deployed-platform differences. - Add `TODO(deploy-test-completion):` comments with the observed or likely blocker for exclusions that should be revisited. - Cover every current `skipDeployment` setting, hand-written suite guard, and manifest-excluded file without changing test execution. This creates an actionable inventory for enabling valid suites while preserving exclusions whose current assertions are inherently local. ## Verification - Confirmed every declarative skip, suite guard, and manifest exclusion has a rationale marker and that every TODO includes a reason. - Confirmed the layer changes comments only. - Prettier and ESLint passed for all affected test files. <!-- NEXT_JS_LLM -->
gnoff
force-pushed
the
jstory/deploy-tests/manifest-cleanup
branch
from
August 28, 2026 23:46
a8e42e4 to
3334ded
Compare
gnoff
force-pushed
the
jstory/deploy-tests/skip-rationales
branch
from
August 28, 2026 23:46
6b6b464 to
af04f26
Compare
gnoff
marked this pull request as ready for review
August 29, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make suite-level deploy-test exclusions explicit and searchable across the e2e test suite.
Deploy mode exclusion:comments for exclusions tied to local processes, local files or build artifacts, and deployed-platform differences.TODO(deploy-test-completion):comments with the observed or likely blocker for exclusions that should be revisited.skipDeploymentsetting, hand-written suite guard, and manifest-excluded file without changing test execution.This creates an actionable inventory for enabling valid suites while preserving exclusions whose current assertions are inherently local.
Verification