Skip to content

test: document deploy test exclusions - #98052

Closed
gnoff wants to merge 1 commit into
jstory/deploy-tests/manifest-cleanupfrom
jstory/deploy-tests/skip-rationales
Closed

gnoff wants to merge 1 commit into
jstory/deploy-tests/manifest-cleanupfrom
jstory/deploy-tests/skip-rationales

Conversation

@gnoff

@gnoff gnoff commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make suite-level deploy-test exclusions explicit and searchable across the e2e test suite.

  • Add Deploy mode exclusion: comments for exclusions tied to local processes, local files or build artifacts, and deployed-platform differences.
  • Add TODO(deploy-test-completion): comments with the observed or likely blocker for exclusions that should be revisited.
  • Cover every current skipDeployment setting, hand-written suite guard, and manifest-excluded file without changing test execution.

This creates an actionable inventory for enabling valid suites while preserving exclusions whose current assertions are inherently local.

Verification

  • Confirmed every declarative skip, suite guard, and manifest exclusion has a rationale marker and that every TODO includes a reason.
  • Confirmed the layer changes comments only.
  • Prettier and ESLint passed for all affected test files.

@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: af04f26 | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts (job)

  • instant-navigation-testing-api - without Cache Components > does not enable instant navigation (DD)
Expand output

● instant-navigation-testing-api - without Cache Components › does not enable instant navigation

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 1

  1214 |
  1215 |         const loadingShell = page.locator('[data-testid="loading-shell"]')
> 1216 |         expect(await loadingShell.count()).toBe(0)
       |                                            ^
  1217 |         await dynamicContent.waitFor({ state: 'visible' })
  1218 |       })
  1219 |     })

  at toBe (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:1216:44)
  at instant (../packages/next-playwright/dist/index.js:75:20)
  at Object.<anonymous> (e2e/app-dir/instant-navigation-testing-api/instant-navigation-testing-api.test.ts:1211:7)

pnpm test-deploy-experimental-turbo test/e2e/app-dir/sub-shell-generation-middleware/sub-shell-generation-middleware.test.ts (turbopack) (Experimental) (job)

  • middleware-static-rewrite > should handle middleware rewrites as well (DD)
Expand output

● middleware-static-rewrite › should handle middleware rewrites as well

expect(received).toMatch(expected)

Expected pattern: /MISS|PRERENDER/
Received string:  "HIT"

  93 |       if (isNextDeploy) {
  94 |         // We produced a partial fallback shell for rewrite/[slug], so we shouldn't see a cache HIT.
> 95 |         expect(getCacheHeader(res)).toMatch(/MISS|PRERENDER/)
     |                                     ^
  96 |       } else {
  97 |         expect(res.headers.get('x-nextjs-cache')).toBe(null)
  98 |       }

  at Object.toMatch (e2e/app-dir/sub-shell-generation-middleware/sub-shell-generation-middleware.test.ts:95:37)

@gnoff
gnoff force-pushed the jstory/deploy-tests/manifest-cleanup branch from 6a63949 to 793b075 Compare August 28, 2026 19:51
@gnoff
gnoff force-pushed the jstory/deploy-tests/skip-rationales branch from fb4f051 to 52702e6 Compare August 28, 2026 19:51
@gnoff
gnoff force-pushed the jstory/deploy-tests/manifest-cleanup branch from 793b075 to a8e42e4 Compare August 28, 2026 23:33
@gnoff
gnoff force-pushed the jstory/deploy-tests/skip-rationales branch from 52702e6 to 6b6b464 Compare August 28, 2026 23:33
## Summary

Make suite-level deploy-test exclusions explicit and searchable across the e2e test suite.

- Add `Deploy mode exclusion:` comments for exclusions tied to local processes, local files or build artifacts, and deployed-platform differences.
- Add `TODO(deploy-test-completion):` comments with the observed or likely blocker for exclusions that should be revisited.
- Cover every current `skipDeployment` setting, hand-written suite guard, and manifest-excluded file without changing test execution.

This creates an actionable inventory for enabling valid suites while preserving exclusions whose current assertions are inherently local.

## Verification

- Confirmed every declarative skip, suite guard, and manifest exclusion has a rationale marker and that every TODO includes a reason.
- Confirmed the layer changes comments only.
- Prettier and ESLint passed for all affected test files.

<!-- NEXT_JS_LLM -->
@gnoff
gnoff force-pushed the jstory/deploy-tests/manifest-cleanup branch from a8e42e4 to 3334ded Compare August 28, 2026 23:46
@gnoff
gnoff force-pushed the jstory/deploy-tests/skip-rationales branch from 6b6b464 to af04f26 Compare August 28, 2026 23:46
@gnoff
gnoff marked this pull request as ready for review August 29, 2026 00:06
@gnoff gnoff closed this Sep 2, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant