Repository navigation
Conversation
Contributor
Tests PassedCommit: 9267ac3 |
gnoff
force-pushed
the
jstory/deploy-tests/skip-rationales
branch
from
August 28, 2026 23:33
52702e6 to
6b6b464
Compare
gnoff
force-pushed
the
jstory/deploy-tests/skip-deployment-blocks
branch
2 times, most recently
from
August 28, 2026 23:46
07887fe to
45664ca
Compare
gnoff
force-pushed
the
jstory/deploy-tests/skip-rationales
branch
from
August 28, 2026 23:46
6b6b464 to
af04f26
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
gnoff
force-pushed
the
jstory/deploy-tests/skip-deployment-blocks
branch
from
August 29, 2026 00:00
45664ca to
010bae1
Compare
gnoff
marked this pull request as ready for review
August 29, 2026 00:05
devjiwonchoi
approved these changes
Aug 29, 2026
## Summary Add a reason-bearing `skipDeployment` test global that reports omitted blocks as skipped without focusing the entire Jest file. Declare the global type from the included test-library module while installing the runtime implementation in Jest setup, so root TypeScript checks can resolve it. Use it for the cache-components dynamic-import external-package block so the deploy-compatible sibling suite is no longer suppressed. ## Verification - `pnpm exec jest --runInBand test/unit/skip-deployment/skip-deployment.test.ts` - `pnpm test-start-turbo test/e2e/app-dir/cache-components-dynamic-imports/cache-components-dynamic-imports.test.ts` - `pnpm lint-typescript --log-order=stream` - `pnpm types:test-lib` <!-- NEXT_JS_LLM -->
gnoff
force-pushed
the
jstory/deploy-tests/skip-deployment-blocks
branch
from
August 29, 2026 21:57
010bae1 to
9267ac3
Compare
eps1lon
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing
@force-gate !deploydirective to exclude only the external-package block in the cache-components dynamic-import suite from deployment testing.The adjacent rationale explains that this block intentionally verifies a failed build, so it cannot produce a deployment. Deploy-compatible sibling tests in the same Jest file remain runnable, and deployment CI reports the excluded block through Jest's native skip mechanism.
Verification
pnpm exec jest --runInBand test/unit/gate/pnpm prettier --with-node-modules --ignore-path .prettierignore --write test/e2e/app-dir/cache-components-dynamic-imports/cache-components-dynamic-imports.test.tsnpx eslint --config eslint.config.mjs --fix test/e2e/app-dir/cache-components-dynamic-imports/cache-components-dynamic-imports.test.ts