Repository navigation
Conversation
bgw
marked this pull request as draft
October 7, 2026 00:33
Contributor
Tests PassedCommit: 19cd777 |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| /// | ||
| /// [gvs]: https://pnpm.io/global-virtual-store | ||
| pub(crate) fn find_global_virtual_store(project_root: &Path, project_path: &str) -> Option<RcStr> { | ||
| let mut dir = project_root.join(project_path); |
Contributor
There was a problem hiding this comment.
Suggested change
| let mut dir = project_root.join(project_path); | |
| // `project_path` is always a Unix-style (`/`-separated) path. Push each component | |
| // individually rather than using `Path::join`, because on Windows forward slashes are not | |
| // treated as separators inside verbatim (`\\?\`-prefixed) paths, which `project_root` is. | |
| let mut dir = project_root.to_path_buf(); | |
| for component in project_path.split('/') { | |
| if !component.is_empty() { | |
| dir.push(component); | |
| } | |
| } |
On Windows, joining a Unix-style (/-separated) project_path to a verbatim (\\?\) project_root treats apps/web as one literal component, breaking the per-project .modules.yaml lookup and the upward directory search.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude slop. Working on reviewing it myself...