Repository navigation
Address follow-up review comments on custom training containers docs - #5420
Merged
Eliza Farley (elizafarley) merged 4 commits intoOct 15, 2026
Merged
Conversation
- Add the optional --dataset-file, --model-output-directory, and --custom-args flags to the training-script test-local summary line. - Show --dataset-file in test-local examples. - Note that --org-id is optional for train containers list. - Clarify that jobs skip dependency installs only when the container includes every dependency the script needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
viambot
added
the
safe to build
Jeremy Rose (jeremyrose-viam)
approved these changes
Oct 14, 2026
| --dataset-root=./my-dataset/ \ | ||
| --training-script-directory=./my-training-script/ \ | ||
| --dataset-file=dataset.jsonl \ | ||
| --container-id=<container-id> |
There was a problem hiding this comment.
Is there a reason you left out model-output-directory here?
…UDA tag - Show --model-output-directory in the datasets-and-training test-local example, matching the other test-local examples. - Replace the specific nvidia/cuda tag in the example Dockerfile with a placeholder, link the nvidia/cuda Docker Hub page, and tell readers to pick a tag with the CUDA version their libraries need. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Any image that meets the listed requirements works, so don't prescribe a CUDA base image or show an unverified example Dockerfile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Eliza Farley (elizafarley)
deleted the
eliza/custom-containers-followups
branch
October 15, 2026 13:51
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5407, addressing Lillian Hwang-Geddes (@lvhg)'s review comments that landed after merge.
docs/cli/reference.md: thetraining-script test-localsummary line now lists the optional--dataset-file,--model-output-directory, and--custom-argsflags instead of[...named args]. The section example also shows--dataset-file. (comment)docs/cli/datasets-and-training.md: notes that--org-idis optional forviam train containers listand that without it the command lists only Viam-managed containers. Thetest-localexample shows--dataset-file. (comment)docs/train/custom-containers.md: clarifies that jobs skip installing dependencies with pip only when the container includes every dependency the training script needs (comment), and adds--dataset-fileto thetest-localexample (comment).Also, from review on this PR:
docs/cli/datasets-and-training.md: thetest-localexample now shows--model-output-directory, like the other examples (comment).docs/train/custom-containers.md: removed the base image guidance and the example Dockerfile, which used an unverifiednvidia/cudatag. Any image that meets the page's listed requirements works, so the section now says to build an image that meets them, starting from any base image.Verified against code
rdkcli/app.goonmain:test-localtakes--dataset-file(defaultdataset.jsonl),--model-output-directory(default.), and--custom-args, all optional.MLListContainersincli/ml_training.gopasses--org-idstraight through with no default-org fallback, so omitting it returns only Viam-managed containers.Checks
prettier 3.2.5, markdownlint, vale,
frontmatter_rules.py, andmake build-prodall pass.🤖 Generated with Claude Code