Repository navigation
Say RegisterCustomTrainingContainer needs a non-empty description - #5430
Merged
Eliza Farley (elizafarley) merged 1 commit intoOct 17, 2026
Merged
Eliza Farley (elizafarley) merged 1 commit into
Eliza Farley (elizafarley) merged 1 commit into
Conversation
viam-python-sdk#1289 removes the empty default from register_custom_training_container because the RPC rejects an empty description. The generated reference still lists the parameter as optional; note the requirement in the proto description override.
✅ Deploy Preview for viam-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Docs review: Ready to mergeAdds a sentence to the CI: All required checks passing Docs health: No regressions (no Nits
Verified against source (3 claims)
Automated review by Claude. Rerunning the review updates this comment. |
Eliza Farley (elizafarley)
approved these changes
Oct 17, 2026
Eliza Farley (elizafarley)
deleted the
claude/update-register-training-container-description
branch
October 17, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Source changes
register_custom_training_containerno longer defaultsdescriptionto"", because theRegisterCustomTrainingContainerRPC rejects an empty description (container description must be specified, appmltraining/ml_training_service.go). Not yet in a published Python release (latest v0.84.0).Documents: no ticket key found (the PR carries none).
Docs changes
static/include/app/apis/overrides/protos/mltraining.RegisterCustomTrainingContainer.md: adds that the description must not be empty. This is true today against every SDK version, since the server enforces it.static/include/app/apis/generated/mltraining.mdandmltraining-table.md: the override text, as the generator renders it.The generated Python parameter line still says
descriptionis optional. It is scraped from python.viam.dev, which still showsdescription: str = '', so regenerating cannot fix it yet. That line is tracked in the docs-agent backlog until python.viam.dev and a published release show the parameter without a default.Regenerated with
update_sdk_methods.py "" app,mltraining(the Go app-client tabs are scraped only whenappis in the resource list). The output is identical to these committed files.How I found these
app-api-xref.md(ML training client)register_custom_training_container,RegisterCustomTrainingContainer,container descriptionacrossdocs/andstatic/: the generated reference anddocs/train/custom-containers.md, whose examples already pass a description.Checks: vale 3.12.0 on the three files,
frontmatter_rules.py,make build-prodall pass. Prettier and markdownlint do not coverstatic/.Generated by daily docs change agent
Generated by Claude Code