Repository navigation
RSDK-14725 Upload raw JSON from windows tests - #6626
Merged
Merged
Conversation
viambot
added
the
safe to test
Benjamin Rewis (benjirewis)
requested a review
from Daniel Botros (danielbotros)
October 9, 2026 21:56
Benjamin Rewis (benjirewis)
marked this pull request as ready for review
October 9, 2026 21:56
Member
Author
|
New workflow ran successfully here. |
Daniel Botros (danielbotros)
approved these changes
Oct 12, 2026
Daniel Botros (danielbotros)
left a comment
Daniel Botros (danielbotros)
left a comment
Member
There was a problem hiding this comment.
LGTM thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSDK-14725
What
Saves the raw JSON from Windows test output and uploads it as an artifact for the test.
Why
We've recently seen errors in Windows test runs indicating that
gotestsumis unable to parse a JSON log line that's > 64kb. Our usage ofgotestsumdoes not save the underlying JSON that it's trying to parse, so we cannot see what the long log line is. This change should let us see it when the error happens again.