Repository navigation
[APP-18037] cli: succeed module reload when GetMachineStatus has no module status - #6638
Merged
Michael Lee (michaellee1019) merged 6 commits intoOct 16, 2026
Conversation
Module status landed in viam-server 1.1.0. Older machines still apply the reload, but the CLI waited 5 minutes and reported a timeout. Co-authored-by: Cursor <cursoragent@cursor.com>
viambot
added
the
safe to test
Michael Lee (michaellee1019)
changed the title
1.0.x GetMachineStatus often leaves Config.LastUpdated stale, so the empty-modules grace never started and the CLI hung for five minutes. Co-authored-by: Cursor <cursoragent@cursor.com>
viambot
added
safe to test
Michael Lee (michaellee1019)
requested review from
Naveed Jooma (njooma) and
Ethan (stuqdog)
October 16, 2026 18:53
viambot
added
safe to test
…e status. Co-authored-by: Cursor <cursoragent@cursor.com>
viambot
added
safe to test
Printing a warning while the progress spinner is active left a leftover waiting line after the wait step completed. Co-authored-by: Cursor <cursoragent@cursor.com>
viambot
added
safe to test
Member
Author
|
Thanks for the review! I just finished the latest round of manual testing: |
Co-authored-by: Cursor <cursoragent@cursor.com>
viambot
added
safe to test
Michael Lee (michaellee1019)
deleted the
cursor/fix-reload-package-before-build-done
branch
October 16, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMachineStatus.modulesafterviam module reloadand confirms that the module has restarted after the code is swapped. That field was added in viam-server 1.1.0.config applied: true, module state: not found) because module status is not implemented.modulesstays empty, treat the reload as complete after a short grace period (or immediately ifGetMachineStatusisUnimplemented).Test plan
viam module reloadagainst a viam-server older than 1.1.0: wait should finish with a warning instead of a 5m timeoutviam module reloadagainst current viam-server: still waits until the named module is ready/unhealthyMade with Cursor