Repository navigation
Improve error logging when detecting shell service name fails - #6664
Merged
Merged
Conversation
viambot
added
the
safe to test
Cheuk (cheukt)
approved these changes
Oct 16, 2026
viambot
added
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor followup from #6601. As part of determining the correct shell service to use for a part the cli now calls
CloudMetadata, and reports that the machine is missing a cloud configuration if that fails in any way. This change attempts to determine if the failure is actually a missing cloud config or something else like a network issue. When the part is missing cloud metadata gRPC returns codeUnknown, which isn't very specific but should be good enough here. Network issues will manifest as other codes likeCancelled,DeadlineExceeded, etc. We could update the server code to return more specific error info like codeNotFoundbut I don't think it's worth the effort.