Repository navigation
Require description in register_custom_training_container - #1289
Open
Jeremy Rose (jeremyrose-viam) wants to merge 1 commit into
Open
Jeremy Rose (jeremyrose-viam) wants to merge 1 commit into
Jeremy Rose (jeremyrose-viam) wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Jeremy Rose (jeremyrose-viam)
marked this pull request as ready for review
October 7, 2026 19:27
Jeremy Rose (jeremyrose-viam)
requested review from
Naveed Jooma (njooma) and
Ethan (stuqdog)
October 7, 2026 19:27
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RegisterCustomTrainingContainerRPC rejects an empty description (container description must be specified), but the client method declaresdescription: str = "". Callers who omit it get a server error, and generated API docs list the parameter as optional.This removes the default and notes in the docstring that the value must not be empty. Callers that already pass
descriptionare unaffected.The
= ""default came in with the generated wrappers in #1267.Tests:
tests/test_ml_training_client.pypasses;ruff checkandruff format --checkare clean.🤖 Generated with Claude Code