Repository navigation
APP-18196: Add refresh_dataset_cache to submit_custom_training_job - #1290
Closed
Katie Peters (katiepeters) wants to merge 1 commit into
Closed
Katie Peters (katiepeters) wants to merge 1 commit into
Katie Peters (katiepeters) wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
refresh_dataset_cache: bool = Falsekeyword argument toMLTrainingClient.submit_custom_training_joband passes it onSubmitCustomTrainingJobRequest. When true, the job exports the dataset fresh instead of reusing a cached export, and replaces the cached export with the new one. The dataset export cache itself is in viamrobotics/app#13890.Also records the field in
MockMLTraining.SubmitCustomTrainingJoband asserts it intest_custom_submit_training_job.Depends on viamrobotics/api#918, which adds
refresh_dataset_cache = 10toSubmitCustomTrainingJobRequest. This PR does not touchsrc/viam/gen. The generated field lands with the automated proto update after the api release. Until then,test_custom_submit_training_joband pyright fail because the request has norefresh_dataset_cachefield.Testing: ruff check/format clean. With
ml_training_pb2regenerated locally from the api branch (not committed),pytest tests/test_ml_training_client.pypasses (10/10) and pyright reports no errors on the client.🤖 Generated with Claude Code