Repository navigation
slurm monitor - #21
Open
MayssaRouissi wants to merge 11 commits into
Open
slurm monitor #21MayssaRouissi wants to merge 11 commits into
MayssaRouissi wants to merge 11 commits into
Conversation
axlbonnet
reviewed
Sep 8, 2026
axlbonnet
left a comment
axlbonnet
left a comment
Contributor
There was a problem hiding this comment.
First review.
I would like the slurm command to be integrated in a similar way as the existing slurm commands.
axlbonnet
reviewed
Sep 14, 2026
axlbonnet
left a comment
axlbonnet
left a comment
Contributor
There was a problem hiding this comment.
Much better, the remote commands seem good.
Still stuff to improve :)
Contributor
|
Also your current branch is |
axlbonnet
reviewed
Sep 15, 2026
| map.put("memoryUsagePct", computeMemPct(fields[4], fields[5])); | ||
| map.put("startTime", fields[6].replace("T", " ")); | ||
| map.put("endTime", fields[7].replace("T", " ")); | ||
| map.put("elapsedTime", normalizeElapsed(fields[8])); |
Contributor
There was a problem hiding this comment.
I did not look yet what you begun to do in the parent GASW project.
The idea is to make the metrics information a common thing in gasw, and not specific to gasw-batch.
Especially:
- the metrics name will be an enum in the gasw project
- all the metrics will be saved in the Job table in the database (with the job dao in gasw)
- i think gasw will ask the metrics to the plugin, which will return the Map (if possible), and gasw will save them in database.
If it's already done, i will review it, otherwise tell me when it's ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.