Repository navigation
fix warning rm -rf - #30
Open
MayssaRouissi wants to merge 3 commits into
Open
MayssaRouissi wants to merge 3 commits into
MayssaRouissi wants to merge 3 commits into
Conversation
axlbonnet
reviewed
Nov 9, 2026
| <groupId>fr.insalyon.creatis</groupId> | ||
| <artifactId>gasw-batch-plugin</artifactId> | ||
| <version>1.3-SNAPSHOT</version> | ||
| <version>1.2.2</version> |
axlbonnet
reviewed
Nov 9, 2026
|
|
||
| channel.open().verify(config.getOptions().getCommandExecutionTimeout(), TimeUnit.SECONDS); | ||
| channel.waitFor(EnumSet.of(ClientChannelEvent.CLOSED, ClientChannelEvent.EXIT_STATUS), config.getOptions().getSshEventTimeout()); | ||
| final Set<ClientChannelEvent> events = channel.waitFor( |
Contributor
There was a problem hiding this comment.
what is the timeout difference with the previous line ?
could we keep the same timeout (CommandExecutionTimeout) which is 10 seconds by default ?
Author
There was a problem hiding this comment.
- the line (chanel.open().verify) only covers opening the channel while the waitFor covers the whole command execution until the exit status arrives.
- the waitFor was using sshEvetTimeout (1000ms) whiwh is too short for a slow rm -rf
- yes,we can keep the same option.
ps: i think that we need to adjust also the executor.json and raise the value up to 10000
added 2 commits
November 12, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.