Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you're not using the Docs Builder properly yet, if you need help to set that up please go to IO Documentation |
|
|
||
| public productsRaw = (args: SearchArgs) => { | ||
| return this.getRaw<SearchProduct[]>(this.productSearchUrl(args), { | ||
| metric: 'search-products', |
There was a problem hiding this comment.
Maybe change metric name to be different from products
There was a problem hiding this comment.
Its supposed to be the same thing, just had to do this for typings. Its still hitting the same url with the same variables. For me, it should be the same. I will ask for a third opinion.
| ) | ||
| } | ||
|
|
||
| const products = await search.products(args) |
There was a problem hiding this comment.
Shouldn't you add skipSimulation = true to the args
| ...product, | ||
| items: product.items.map(item => ({ | ||
| ...item, | ||
| skippedSimulation: !!skipSimulation, |
There was a problem hiding this comment.
Skip simulation is a boolean, !! isn't needed
There was a problem hiding this comment.
it might be null or undefined, lets say someone pass the wrong value in the resolver above the tree. I think this is safer.
de9d04d to
0bff87b
Compare
What problem is this solving?
How should this be manually tested?
https://fidelis--alssports.myvtex.com/_v/private/vtex.search-graphql@0.8.1/graphiql/v1?
Checklist/Reminders
README.md.CHANGELOG.md.Screenshots or example usage
Type of changes
Notes