Repository navigation
fixed faulty explanation in timefield - #1185
Merged
Merged
Conversation
EHandtkeBasis
requested review from
MatthewHawkins,
bbrennanbasis,
gosteenBASIS,
hyyan and
laurenic0l
as code owners
September 28, 2026 10:19
EHandtkeBasis
added
the
status: waiting-for-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| The `TimeField` class also provides the following static utility methods: | ||
|
|
||
| - `fromTime(String timeAsString)`: Convert a time string in HH:mm:ss format to a LocalTime object which can then be utilized with this class, or elsewhere. | ||
| - `fromTime(String timeAsString)`: Parse a time string, with or without seconds, into a `LocalTime` truncated to minutes. |
Contributor
There was a problem hiding this comment.
'Parse' should be in lowercase.
| - `fromTime(String timeAsString)`: Parse a time string, with or without seconds, into a `LocalTime` truncated to minutes. | ||
|
|
||
| - `toTime(LocalTime time)`: Convert a LocalTime to a time string in HH:mm:ss format. | ||
| - `toTime(LocalTime time)`: Convert a `LocalTime` to a string in `HH:mm` format, discarding seconds. |
Contributor
There was a problem hiding this comment.
'Convert' should be in lowercase.
| - `toTime(LocalTime time)`: Convert a `LocalTime` to a string in `HH:mm` format, discarding seconds. | ||
|
|
||
| - `isValidTime(String timeAsString)`: Check if the given string is a valid HH:mm:ss time. This will return a boolean value true if so, false otherwise. | ||
| - `isValidTime(String timeAsString)`: Check whether a time string is valid, including `HH:mm` and `HH:mm:ss` inputs. Returns `true` if valid and `false` otherwise. |
Contributor
There was a problem hiding this comment.
'Check' should be in lowercase.
| - **Accessibility**: Utilize the `TimeField` component with accessibility in mind, ensuring it meets accessibility standards such as providing proper labels, sufficient color contrast, and compatibility with assistive technologies. | ||
|
|
||
| - **Reset Option**: Provide a way for users to easily clear the `TimeField` to an empty or default state. No newline at end of file | ||
| - **Reset Option**: Provide a way for users to easily clear the `TimeField` to an empty or default state. |
Contributor
There was a problem hiding this comment.
'Provide' should be in lowercase.
laurenic0l
approved these changes
Oct 1, 2026
| - **Provide Clear Time Format Examples**: Clearly show users the expected time format near the `TimeField`. Use examples or placeholders to help them enter the time correctly. If possible, display the time format based on the user's location. | ||
|
|
||
| - **Accessibility**: Utilize the `TimeField` component with accessibility in mind, ensuring it meets accessibility standards such as providing proper labels, sufficient color contrast, and compatibility with assistive technologies. | ||
| - **Accessibility**: Use the `TimeField` component with accessibility in mind, meeting accessibility standards such as proper labels, sufficient color contrast, and compatibility with assistive technologies. |
Contributor
There was a problem hiding this comment.
'Use' should be in lowercase.
gosteenBASIS
approved these changes
Oct 7, 2026
gosteenBASIS
left a comment
gosteenBASIS
left a comment
Member
There was a problem hiding this comment.
Looks good; added a couple minor grammar/wording fixes to reduce Vale warnings.
gosteenBASIS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1153