fix(app-website-builder): make sidebar settings scroll to the bottom - #5528
Open
adrians5j wants to merge 1 commit into
Open
fix(app-website-builder): make sidebar settings scroll to the bottom#5528adrians5j wants to merge 1 commit into
adrians5j wants to merge 1 commit into
Conversation
The sidebar tab content computed its height with a hardcoded top-bar estimate (calc(100vh - 44px - 49px)). When the real chrome above the editor was taller than 44px, the scroll box overflowed the viewport and its bottom rows became unreachable. Use the runtime-measured uiReservedSpace.height (the same value the canvas uses) instead of guessing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the page editor's settings sidebar (Element / Style tabs), you can't scroll all the way to the bottom of a long form — the last fields are cut off and unreachable. Reported by Pavel (Slack): "neki height je krivo iskalkuliran" (some height is miscalculated).
Root cause
The sidebar tab content (
TabContainer) sized itself with a hardcoded estimate of the chrome above the editor:When the real top chrome is taller than the guessed
44px(top bar + address bar + review banner, etc.), the scroll box ends up taller than the viewport, so its bottom — and the last form fields — fall below the fold and can't be scrolled into view.Fix
The canvas already solves this correctly:
PreviewContainersizes itself withcalc(100vh - uiReservedSpace.height), whereuiReservedSpace.heightis the top chrome height measured at runtime (useReservedUISpace). The sidebar now uses that same measured value instead of guessing:One file,
app-website-builderonly — no shared-package changes.Verification
49pxis the tab-header height; if a small gap/overflow appears at the bottom it can be nudged.🤖 Generated with Claude Code