Skip to content

fix(app-website-builder): make sidebar settings scroll to the bottom - #5528

Open
adrians5j wants to merge 1 commit into
release/6.4.6from
claude/sidebar-settings-scroll-6.4.6
Open

fix(app-website-builder): make sidebar settings scroll to the bottom#5528
adrians5j wants to merge 1 commit into
release/6.4.6from
claude/sidebar-settings-scroll-6.4.6

Conversation

@adrians5j

Copy link
Copy Markdown
Member

Problem

In the page editor's settings sidebar (Element / Style tabs), you can't scroll all the way to the bottom of a long form — the last fields are cut off and unreachable. Reported by Pavel (Slack): "neki height je krivo iskalkuliran" (some height is miscalculated).

Root cause

The sidebar tab content (TabContainer) sized itself with a hardcoded estimate of the chrome above the editor:

height: calc(100vh - 44px - 49px)  // 44px = top bar (guessed), 49px = tab header

When the real top chrome is taller than the guessed 44px (top bar + address bar + review banner, etc.), the scroll box ends up taller than the viewport, so its bottom — and the last form fields — fall below the fold and can't be scrolled into view.

Fix

The canvas already solves this correctly: PreviewContainer sizes itself with calc(100vh - uiReservedSpace.height), where uiReservedSpace.height is the top chrome height measured at runtime (useReservedUISpace). The sidebar now uses that same measured value instead of guessing:

height: calc(100vh - ${uiReservedSpace.height}px - 49px)

One file, app-website-builder only — no shared-package changes.

Verification

  • Please confirm in the editor: open element settings with a long form (e.g. the video/CTA element) and scroll to the last field, on both the Element and Style tabs.
  • The remaining 49px is the tab-header height; if a small gap/overflow appears at the bottom it can be nudged.

🤖 Generated with Claude Code

The sidebar tab content computed its height with a hardcoded top-bar estimate
(calc(100vh - 44px - 49px)). When the real chrome above the editor was taller
than 44px, the scroll box overflowed the viewport and its bottom rows became
unreachable. Use the runtime-measured uiReservedSpace.height (the same value the
canvas uses) instead of guessing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant