Add keyboard support for Tsishingini (tsw) - #860
Merged
Merged
Conversation
srish
requested changes
Aug 19, 2026
srish
left a comment
srish
left a comment
Member
There was a problem hiding this comment.
@ToluAyodele Thanks Tolu for the PR! I've left some comments inline.
Besides these comments, there is one Git related issue. It looks like your git author meta data might be broken: “ToluAyo” <“tayodele-ctr@wikimedia.org”> - name and email are wrapped in curly quotes, so the email is invalid and won't attribute. Every of your other commit uses ToluAyodele <129562437+ToluAyodele@users.noreply.github.com>. Might need a git commit --amend --author=.....
ToluAyodele
force-pushed
the
T428848
branch
2 times, most recently
from
August 24, 2026 16:15
0e18f3e to
8f2c367
Compare
srish
requested changes
Aug 24, 2026
srish
left a comment
srish
left a comment
Member
There was a problem hiding this comment.
@ToluAyodele Thanks for making additional changes. I've left some comments inline that need to be addressed before we can merge this.
srish
requested changes
Aug 26, 2026
srish
left a comment
srish
left a comment
Member
There was a problem hiding this comment.
We are close to getting this merged.
Added marking tones: [ '~/', '\u0301' ], // á high tone [ '~\\', '\u0300' ], // à low tone [ '~\^', '\u0302' ] // â falling tone Updated pattern for the ɔ/Ɔ characters from ~c/~C to ~o/~O Updated the glottal stop from U+2019 to U+02BC
srish
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream task: https://phabricator.wikimedia.org/T428848