Add Perso Arabic and Khudabadi Sindhi keyboards - #863
ToluAyodele wants to merge 9 commits into
Conversation
This file defines a new keyboard layout for Sindhi Perso Arabic, including key mappings and metadata.
srish
left a comment
srish
left a comment
There was a problem hiding this comment.
@ToluAyodele I've left some minor comments inline and addressing them might require inputs from @Siddharth-Talreja.
| { input: 'qwerty', output: '𑋨𑋦𑋠𑋢𑋤𑋔', description: 'Sindhi InScript Khudabadi qwerty' }, | ||
| { input: 'asdfgh', output: '𑋧𑋥𑋪𑋡𑋣𑋒', description: 'Sindhi InScript Khudabadi asdfgh' }, | ||
| { input: 'jkl;', output: '𑋙𑊺𑋍𑋀', description: 'Sindhi InScript Khudabadi jkl;' }, | ||
| { input: 'ZXCVBNM', output: 'ZX𑋌𑋉𑋕𑋃𑋜', description: 'Sindhi InScript Khudabadi ZXCVBNM' } |
There was a problem hiding this comment.
The X key isn't mapped. It just types an English X here. As per AI, it should be mapped as [ 'x', '𑋟' ] and it is needed to write nasal sounds in Sindhi. Probably @Siddharth-Talreja can help verify.
There was a problem hiding this comment.
Yes, the key is needed. Probably I forgot about this particular mapping in the previous PR. Sorry for the inconvenience.
| [ 'h', 'ھ' ], | ||
| [ 'J', 'جھ' ], | ||
| [ 'j', 'ج' ], | ||
| [ 'K', 'ۡ' ], |
There was a problem hiding this comment.
@Siddharth-Talreja Can you verify whether U+0652 should replace the character here?
| [ 'i', 'ڳ' ], | ||
| [ 'O', 'ُ' ], | ||
| [ 'o', 'و' ], | ||
| [ 'P', 'ڦ' ], |
| author: 'Siddharth Talreja', | ||
| license: 'GPLv3', | ||
| version: '1.0', | ||
| patterns: [ |
There was a problem hiding this comment.
Should there be a key for ه on this keyboard?
There was a problem hiding this comment.
It may be added if possible as it may used in some cases. Also regarding the ambiguity of g+h and G which you had previously asked, both combinations must be kept. While this will probably introduce ambiguity in the system, current usage uses both forms interchangeably, including on Wikipedia. Hence to search and correctly use the already existing data, both forms are needed.
|
@srish is there a way we can add a rule for typing the special character ﷲ like as a single character or a combination of ا ل ل ھ |
Add inputmethods and test fixtures for keyboard input
042a159 to
0d40adf
Compare
3 participants
Bug: https://phabricator.wikimedia.org/T428126