fix: correctly resolve linker script functions that return addresses - #2413
Merged
davidlattimore merged 3 commits intoAug 17, 2026
Merged
Conversation
Signed-off-by: Vishruth Thimmaiah <vishruththimmaiah@gmail.com>
vishruth-thimmaiah
marked this pull request as ready for review
August 17, 2026 09:26
| .data.flash : { | ||
| KEEP(*(.data.flash)) | ||
| } > FLASH | ||
| ASSERT(ORIGIN(FLASH) == 0x40000000, "ROM region must start at 0x20000000") |
Member
There was a problem hiding this comment.
Message doesn't match assertion. Feel free to not include the address in the message if that makes it easier :)
Signed-off-by: Vishruth Thimmaiah <vishruththimmaiah@gmail.com>
davidlattimore
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions such as
ADDR,LOADADDR,SEGMENT_STARTandORIGINreturn an address instead of a number. Addresses must be treated as an absolute value, instead of being relative to an output section.Additionally, comparison operators like
==, etc must resolve any relative values to their absolute value before performing a comparison.