Repository navigation
fix(veracrypt): website changes moved version number - #2066
philclifford wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
2 issues found across 1 file
Confidence score: 3/5
- In
01-main/packages/veracrypt, the version pipeline can emit multiple matches and create a malformed download URL. Limit it to the first match. - In
01-main/packages/veracrypt, thearm64target still requests ajammypackage that the current VeraCrypt release does not publish. Removejammyfrom that target matrix or add a supported fallback.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="01-main/packages/veracrypt">
<violation number="1" location="01-main/packages/veracrypt:5">
P2: `arm64` still advertises `jammy`, so the generated URL requests `Ubuntu-22.04-arm64.deb`, which the current VeraCrypt release does not publish. Remove `jammy` from this target matrix or provide a supported fallback.
(Based on your team's feedback about matching supported package targets.) [85b2a2f4-31df-4d58-ab07-00f540ef9d31]</violation>
<violation number="2" location="01-main/packages/veracrypt:11">
P2: This pipeline can return more than one version string if the matched line contains several, which would produce a malformed download URL. Limit the output to the first match.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| URL=$(unroll_url "https://launchpad.net/veracrypt/trunk/${VERSION_PUBLISHED}/+download/veracrypt-${VERSION_PUBLISHED}-${UPSTREAM_ID^}-${UPSTREAM_RELEASE}-${HOST_ARCH}.deb\"") | ||
| #VERSION_PUBLISHED=$(sed -En 's|.*Latest\s+Stable\s+Release\s*-?\s*(\S+).*|\1|p' "${CACHE_FILE}") | ||
| VERSION_PUBLISHED=$(grep -A5 -E 'Latest\s+Stable\s+Release\s*' "${CACHE_FILE}" | grep Linux | grep -Eo '[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+') |
There was a problem hiding this comment.
P2: This pipeline can return more than one version string if the matched line contains several, which would produce a malformed download URL. Limit the output to the first match.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At 01-main/packages/veracrypt, line 11:
<comment>This pipeline can return more than one version string if the matched line contains several, which would produce a malformed download URL. Limit the output to the first match.</comment>
<file context>
@@ -1,16 +1,18 @@
-
- URL=$(unroll_url "https://launchpad.net/veracrypt/trunk/${VERSION_PUBLISHED}/+download/veracrypt-${VERSION_PUBLISHED}-${UPSTREAM_ID^}-${UPSTREAM_RELEASE}-${HOST_ARCH}.deb\"")
+ #VERSION_PUBLISHED=$(sed -En 's|.*Latest\s+Stable\s+Release\s*-?\s*(\S+).*|\1|p' "${CACHE_FILE}")
+ VERSION_PUBLISHED=$(grep -A5 -E 'Latest\s+Stable\s+Release\s*' "${CACHE_FILE}" | grep Linux | grep -Eo '[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+')
+ # launchpad.net is under sustained DDoS attack, so we switch to github releases for now. We can switch back to launchpad.net once the attack is over.
+ # URL=$(unroll_url "https://launchpad.net/veracrypt/trunk/${VERSION_PUBLISHED}/+download/veracrypt-${VERSION_PUBLISHED}-${UPSTREAM_ID^}-${UPSTREAM_RELEASE}-${HOST_ARCH}.deb\"")
</file context>
| VERSION_PUBLISHED=$(grep -A5 -E 'Latest\s+Stable\s+Release\s*' "${CACHE_FILE}" | grep Linux | grep -Eo '[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+') | |
| VERSION_PUBLISHED=$(grep -A5 -E 'Latest\s+Stable\s+Release\s*' "${CACHE_FILE}" | grep Linux | grep -Eo '[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+' | head -n 1) |
| arm64) CODENAMES_SUPPORTED="bullseye bookworm trixie jammy noble" ;; | ||
| armhf) CODENAMES_SUPPORTED="bullseye bookworm trixie focal" ;; | ||
| amd64) CODENAMES_SUPPORTED="bullseye bookworm trixie jammy noble questing resolute" ;; | ||
| arm64) CODENAMES_SUPPORTED="trixie jammy noble questing resolute" ;; |
There was a problem hiding this comment.
P2: arm64 still advertises jammy, so the generated URL requests Ubuntu-22.04-arm64.deb, which the current VeraCrypt release does not publish. Remove jammy from this target matrix or provide a supported fallback.
(Based on your team's feedback about matching supported package targets.) [85b2a2f4-31df-4d58-ab07-00f540ef9d31]
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At 01-main/packages/veracrypt, line 5:
<comment>`arm64` still advertises `jammy`, so the generated URL requests `Ubuntu-22.04-arm64.deb`, which the current VeraCrypt release does not publish. Remove `jammy` from this target matrix or provide a supported fallback.
(Based on your team's feedback about matching supported package targets.) [85b2a2f4-31df-4d58-ab07-00f540ef9d31]</comment>
<file context>
@@ -1,16 +1,18 @@
- arm64) CODENAMES_SUPPORTED="bullseye bookworm trixie jammy noble" ;;
- armhf) CODENAMES_SUPPORTED="bullseye bookworm trixie focal" ;;
+ amd64) CODENAMES_SUPPORTED="bullseye bookworm trixie jammy noble questing resolute" ;;
+ arm64) CODENAMES_SUPPORTED="trixie jammy noble questing resolute" ;;
+ #armhf) CODENAMES_SUPPORTED="bullseye bookworm trixie focal" ;;
esac
</file context>
| arm64) CODENAMES_SUPPORTED="trixie jammy noble questing resolute" ;; | |
| arm64) CODENAMES_SUPPORTED="trixie noble questing resolute" ;; |
|
fixed in #2065 |
No description provided.