Repository navigation
wolfTPM2: harden PCR/hash wrapper validation - #554
Merged
Merged
Conversation
- ReadPCR: reject an empty response (count == 0) before dereferencing digests[0] - HashStart: reject any non-hash algorithm (digest size 0), not just TPM_ALG_NULL - ExtendPCR / ResetPCR: bound pcrIndex to [PCR_FIRST, PCR_LAST], matching ReadPCR
aidangarske
reviewed
Jul 22, 2026
aidangarske
left a comment
aidangarske
left a comment
Member
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-security + bugsOverall recommendation: COMMENT
Findings: 1 total — 1 posted, 0 skipped
1 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] [review+review-security] New wrapper validation paths are not covered by regression tests —
src/tpm2_wrap.c:6695-7725
Review generated by Skoll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defensive-validation improvements in the PCR/hash wrappers:
reading digests[0] uninitialized.
TPM2_GetHashDigestSize(), not only TPM_ALG_NULL.
No API change; builds clean.